Reviewed 4 of 4 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewable status: complete! all files reviewed, all discussions resolved

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)

a discussion (no related file):
Can we extend this to JSON? e.g:

  {
      "delete": [
        {
          "uid": "0x12345",
         "name@es": null
        }
      ]
    }

equivalent to:

<0x12345> <name@es> * .

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain and @MichelDiz)

a discussion (no related file):

it should already work for JSON if the two representations are identical (produce the same DirectedEdge object when parsed). I'll add a test to the json parser to verify this is the case.

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @MichelDiz)

a discussion (no related file):

Added tests but this is the right syntax.

{
      "delete": [
        {
          "uid": "0x12345",
         "name@es": ""
        }
      ]
 }

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @MichelDiz)

a discussion (no related file):

Done.

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)

a discussion (no related file):

I see, the empty string works indeed. But Docs says that "rating": null is a S P * operation syntax. https://docs.dgraph.io/mutations/#deleting-edges - If empty strings are to be considered, for me it's okay.

Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @manishrjain)

Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @manishrjain)

a discussion (no related file):

This seems like a bug. The language tag is not being parsed properly. I'll revert these test changes and open a new PR to fix the bug. But otherwise, JSON support should work out of the box.

And how would this deletion work in JSON?

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

I had to submit #3243 to make this work but it should work in the following way:

{
 "uid":"0xa",
"name@en":null
}

Reviewable status: complete! all files reviewed, all discussions resolved